Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: explicitly set analyze sample number if tidb_analyze_version = 2 #27402

Merged
merged 8 commits into from
Aug 24, 2021
Merged

br: explicitly set analyze sample number if tidb_analyze_version = 2 #27402

merged 8 commits into from
Aug 24, 2021

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Aug 19, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #27391

Problem Summary: Analyze table OOM easily when tidb_analyze_version = 2

What is changed and how it works?

Add explicitly analyze parameter WITH NUM 10000 if the TiDB's tidb_analyze_version = 2 and there are more than 600 regions in target table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • test with 100GB source data, before this pr, target tidb(8core, 16GB mem) always OOM; after this PR, analyze run successfully with tidb peak memory about 1.5GB. BTW, run analyze table and analyze table with 10000 samples results in the same result(with tidb_build_stats_concurrency = 20; which the default lightning config).
  • No code

Side effects

Documentation

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Little-Wallace
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 19, 2021

/component lightning
/assign @chrysan @kennytm @Little-Wallace @3pointer

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Aug 19, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 20, 2021

/run-check_dev

@kennytm
Copy link
Contributor

kennytm commented Aug 20, 2021

release-5.2? is this a cherry-pick of some PR not listed, or #27391 does not affect master?

@glorv
Copy link
Contributor Author

glorv commented Aug 20, 2021

release-5.2? is this a cherry-pick of some PR not listed, or #27391 does not affect master?

@kennytm This is only a work-around for v5.2 due to the unmature of v2 analyze.

cc @chrysan @winoros

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-check_dev

Little-Wallace
Little-Wallace approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
kennytm
kennytm reviewed Aug 23, 2021
View reviewed changes
br/pkg/lightning/restore/table_restore.go Outdated
// TODO: because tidb v5.2 analyze full table OOM easily, we fallback to add `WITH NUM 10000` parameter
// if there are more than 600 regions in this table
sql := "ANALYZE TABLE "+tr.tableName
result, err := g.QueryStringsWithLog(ctx, "SHOW VARIABLES LIKE 'tidb_analyze_version'", "fetch tidb analyze version", tr.logger)
Copy link
Contributor

@kennytm kennytm Aug 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just select @@tidb_analyze_version 😕 (fallback to 1 on error)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally want to be compatible with v4.0, but It's simplier to fallback to 1 on error.

@yudongusa yudongusa mentioned this pull request Aug 23, 2021
Closed
@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/run-check_dev

4 similar comments
@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/run-check_dev

@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/run-check_dev

@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/run-check_dev

@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 24, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 24, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45d454a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@ti-chi-bot
Copy link
Member

@glorv: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3d88be8 into pingcap:release-5.2 Aug 24, 2021
@glorv glorv deleted the analyze-sample branch August 24, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@Little-Wallace Little-Wallace Little-Wallace approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @ti-chi-bot @kennytm @Little-Wallace @zhouqiang-cl